fix: Line breaks aren't properly ignored in lists #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI mode was unconditionally applying WithPreservedNewLines() which caused line breaks to always be preserved regardless of the --preserve-new-lines (-n) flag setting. This made CLI mode behave differently from TUI mode where the flag is properly respected. The fix makes CLI mode consistent with TUI mode by only applying WithPreservedNewLines() when the preserveNewLines config option is true. Fixes charmbracelet#858 Signed-off-by: majiayu000 <[email protected]>
majiayu000
requested review from
aymanbagabas and
kujtimiihoxha
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #858
Changes
WithPreservedNewLines()conditional based on the--preserve-new-linesflagPreviously,
glamour.WithPreservedNewLines()was always applied, causing all line breaks (including soft breaks in lists) to be preserved. Now it respects the CLI flag.