fix(file): use height parameter as max height #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While adding the padding parameter to file, the component has been refactored to use `m.filepicker.SetHeight` instead of the deprecated property `m.filepicker.Height`. Since this change, the size has been calculated based of the window height, overriding the value passed with `--height`. This adds a new `maxHeight` property to constrain the maximum height of the file picker to the value passed by `--height`. Refs: 6045525, charmbracelet#969
davidferneding
requested review from
aymanbagabas and
kujtimiihoxha
and removed request for
a team
|
Hello @davidferneding, I try your solution to solve the bug in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding the padding parameter to file, the component has been refactored to use
m.filepicker.SetHeightinstead of the deprecated propertym.filepicker.Height. Since this change, the size has been calculated based on the window height, overriding the value passed with--height.This adds a new
maxHeightproperty to constrain the maximum height of the file picker to the value passed by--height. The current behaviour of constraining the height to the window height has been preserved.Refs: 6045525
Fixes #969