Skip to content

feat!: v2 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat!: v2 #609

wants to merge 12 commits into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 31, 2025

  • updates everything to v2
  • spinner is not its own module anymore - it had little reason to, IMHO - I also propose we move it into the root huh package btw
  • spinner examples moved into ./examples
  • renamed some of the spinner methods to be more similar to the rest of huh
  • styling spinner the same way we do the rest (themes, dark mode, etc)

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Mar 31, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner March 31, 2025 20:41
@caarlos0 caarlos0 requested review from raphamorim and removed request for a team March 31, 2025 20:41
@bashbunni
Copy link
Member

is it possible that the rationale behind spinner being in its own package was to have a standalone spinner that's possibly easier to set up than the bubbles spinner without needing to import the whole huh module? 🤔

@bashbunni
Copy link
Member

Slight change to outputs
image (this terminal emulator is showing padding with the teal underline). I added a Log statement to see the ansi and here's what it showed:
huh_test.go:1418: "\x1b[1;38;2;90;86;224mPassword:\x1b[m\u00a0\n"

Seems the space after the field title has been removed or is now styled whitespace instead.

@bashbunni
Copy link
Member

bashbunni commented Apr 22, 2025

I just removed the unstyled whitespace from the test cases, so they now pass. We can either do that or strip ansi before comparing got & want. Up to you on what you'd prefer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants