-
Notifications
You must be signed in to change notification settings - Fork 168
feat!: v2 #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
caarlos0
wants to merge
12
commits into
main
Choose a base branch
from
v2-exp-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
caarlos0
commented
Mar 31, 2025
•
edited
Loading
edited
- updates everything to v2
- spinner is not its own module anymore - it had little reason to, IMHO - I also propose we move it into the root huh package btw
- spinner examples moved into ./examples
- renamed some of the spinner methods to be more similar to the rest of huh
- styling spinner the same way we do the rest (themes, dark mode, etc)
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
is it possible that the rationale behind spinner being in its own package was to have a standalone spinner that's possibly easier to set up than the bubbles spinner without needing to import the whole huh module? 🤔 |
I just removed the unstyled whitespace from the test cases, so they now pass. We can either do that or strip ansi before comparing got & want. Up to you on what you'd prefer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.