feat(input): dynamic default values #626
Open
+95
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default values are a special type of placeholder that is treated as the field's actual value when the value would otherwise be empty. The existing default value mechanism, the field's "initial value" is fully static in its current implementation. Although it may be possible to make that mechanism more dynamic in-place, that would have been a much more invasive change. Treating default values more like the placeholder value is more consistent with the rest of the dynamic forms API and also yields a slightly better default user experience.
|
Just checking in here. Is there anything I can do to move this PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values are a special type of placeholder that is treated as the field's actual value when the value would otherwise be empty. The existing default value mechanism — the field's "initial value" — is regularly clobbered by the value read from the textinput bubble once the form is running, which makes it effectively static.
It might be possible to make that "initial value" mechanism more dynamic, but leveraging the placeholder for default values instead (as this PR does) allows dynamic defaults to be more consistent with the rest of the dynamic forms API and it also yields a slightly better user experience by allowing default values to be treated and themed differently than user-entered values.
Fixes the issue raised in #582 (comment).
The 2nd commit updates the themes to display default values differently than placeholders. This isn't strictly necessary, but since they behave slightly differently, they probably should look different too.