Skip to content

Center viewport on selected option #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

edsonmedina
Copy link

This fixes bug #628

@edsonmedina edsonmedina requested a review from a team as a code owner April 15, 2025 17:03
@edsonmedina edsonmedina requested review from andreynering and removed request for a team April 15, 2025 17:03
@caarlos0
Copy link
Member

I don't think we need all these changes 🤔

gonna push a pr with a one line change that I think does the trick as well

@caarlos0
Copy link
Member

see #632

ps: it wont "center" the option, just make sure it's visible

let me know what you think

@edsonmedina
Copy link
Author

ps: it wont "center" the option, just make sure it's visible
let me know what you think

Yeah, I tried making it visible (first option on the viewport), but IMO it made it feel like it was the first option on the list (it wasn't clear that there were more options above), but that's just personal taste, not a bug.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants