Skip to content

fix: Replace \n with a space in Inline style #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Replace \n with a space in Inline style #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21a0c7b
fix: Replace with a space in Inline style
griimick Oct 9, 2022
a543e71
fix: trim trailing newline in Inline
griimick Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion style.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ func (s Style) Render(str string) string {

// Strip newlines in single line mode
if inline {
str = strings.ReplaceAll(str, "\n", "")
str = strings.Trim(str, "\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up: this also trims leading newlines. It may or may not be what we want here, I'll still have to think about the implications some more.

str = strings.ReplaceAll(str, "\n", " ")
}

// Word wrap
Expand Down