feat(tree): modify children of existing Tree
#461
+311
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2025
| } | ||
| case Node: | ||
| nodes = append(nodes, item) | ||
| case fmt.Stringer: |
There was a problem hiding this comment.
Might be useful to support encoding.TextMarshaler as well
There was a problem hiding this comment.
We don't have this in other type checks in tree, maybe something we can add down the line
|
Need to look at the feedback from #452 more closely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to modify existing
Trees. In the current version of this table, there is no way to change existing children outside of adding a new child withTree.Child().This also handles operations on
Leaftypes to turn them intoTrees.See examples for usage on these changes. Those examples are testable, so see their output in comment to see how these API changes work.
Related: #452