Skip to content

fix(table): Mind borders when computing table width #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(table): Mind borders when computing table width #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions table/resizing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
r := newResizer(t.width, t.height, t.headers, rows)
r.wrap = t.wrap
r.borderColumn = t.borderColumn
r.borderLeft = t.borderLeft
r.borderRight = t.borderRight
r.yPaddings = make([][]int, len(r.allRows))

var allRows [][]string
Expand Down Expand Up @@ -125,6 +127,8 @@

wrap bool
borderColumn bool
borderLeft bool
borderRight bool
yPaddings [][]int // vertical paddings
}

Expand Down Expand Up @@ -368,6 +372,15 @@
maxTotal += column.max + r.xPaddingForCol(j)
}
}
if r.borderLeft {
maxTotal += 1

Check failure on line 376 in table/resizing.go

View workflow job for this annotation

GitHub Actions / lint / lint (ubuntu-latest) 

increment-decrement: should replace maxTotal += 1 with maxTotal++ (revive)
}
if r.borderColumn {
maxTotal += r.columnCount() - 1
}
if r.borderRight {
maxTotal += 1

Check failure on line 382 in table/resizing.go

View workflow job for this annotation

GitHub Actions / lint / lint (ubuntu-latest) 

increment-decrement: should replace maxTotal += 1 with maxTotal++ (revive)
}
return
}

Expand Down
Loading