Skip to content

chore: rename Complete to CompleteColor #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v2-exp
Choose a base branch
from
Open

chore: rename Complete to CompleteColor #579

wants to merge 1 commit into from

Conversation

@meowgorithm
Copy link
Member

@meowgorithm meowgorithm commented Oct 20, 2025

This revision renames Complete to CompleteColor and CompleteFunc to CompleteColorFunc. Out of context, Complete is too ambiguous, particularly because the scope of Lip Gloss is beyond color.

aymanbagabas
aymanbagabas reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rename LightDark to LightDarkColor? IMO, these two types don't really represent colors but more like color helpers.

@meowgorithm
Copy link
Member Author

meowgorithm commented Oct 30, 2025

@aymanbagabas I think LightDark is fine as-is because it implies color (or, at least, luminance). I'm fine if Complete is something other than CompleteColor but we need something beyond Complete to make it more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aymanbagabas aymanbagabas aymanbagabas left review comments

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meowgorithm @caarlos0 @aymanbagabas