fix: replace newlines with spaces in Inline mode#633
Open
alexchenai wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix: replace newlines with spaces in Inline mode#633alexchenai wants to merge 1 commit intocharmbracelet:mainfrom
alexchenai wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
…them When Inline(true) is set, newlines were stripped entirely, causing "hello\nworld" to render as "helloworld". This changes the behavior to replace newlines with spaces, producing "hello world" instead, which preserves word boundaries as expected. Fixes charmbracelet#116 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inline(true)now replaces newlines with spaces instead of stripping them entirelystyle.Render("hello\nworld")withInline(true)now produces"hello world"instead of"helloworld"Details
The single-character change in
style.goline 404 replaces""with" "in the newline replacement, preserving word boundaries when rendering inline text. This matches the expected behavior described in the issue — newlines should become spaces, not disappear.Test plan
go test ./...)TestInlineReplacesNewlinesWithSpacestest added and passingNewStyle().Inline(true).Render("hello\nworld")returns"hello world"🤖 Generated with Claude Code