docs: amend inline docs for height calculation#637
Open
bntrtm wants to merge 1 commit intocharmbracelet:mainfrom
Open
docs: amend inline docs for height calculation#637bntrtm wants to merge 1 commit intocharmbracelet:mainfrom
bntrtm wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
bntrtm
force-pushed
the
amend-height-func-docs
branch
from
300f5a2 to
259d9cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding clarity here can help us to avoid situations where a developer may read the documentation via IDE tooling and work on a false assumption that
lipgloss.Heightdoes not account for the fact that at least one line in the input string won't have a newline, when in fact it does (hence the+1).I contend that we have already seen an example of this likely occurring within the
filepickermodel in thebubblesrepo.