fix: terminate margin background on each line#711
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Style each top/bottom margin line individually so the background reset lands before the newline instead of the next line's start, and color the bottom margin line. Fixes charmbracelet#115. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
MarginBackground, the SGR reset landed on the wrong side of the newline: on the top margin the[0mreset appeared at the start of the following line instead of the end of the margin line, and the bottom margin line was left uncolored (#115).applyMarginsstyled the wholespaces\n…block in one call, soStyledplaced the reset after the trailing newline. This styles each margin line on its own so the reset terminates the line before its newline.NewStyle().MarginBackground(Color("9")).Margin(1, 0).Render("hi"):Added a regression test; the full suite passes.
Fixes #115