-
Notifications
You must be signed in to change notification settings - Fork 159
feat(copilot): adds github copilot login support #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nathabonfim59
wants to merge
9
commits into
charmbracelet:main
Choose a base branch
from
nathabonfim59:copilot-login.main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4f4a58c
feat(copilot): add new auth flow with device code
nathabonfim59 6d166d7
fix(copilot): correct verification URI and interval parsing in device…
nathabonfim59 68d226c
feat(copilot): implement device flow authentication
nathabonfim59 29b7660
fix(copilot): remove unreachable code in OAuth token retrieval
nathabonfim59 fef423c
feat(copilot): add a 30s delay before authCallback
nathabonfim59 340578c
fix(copilot): create config directory before saving the oAuthToken
nathabonfim59 d2651d6
chore(copilot): fix styling and linting errors
nathabonfim59 8ec019c
Merge branch 'main' into copilot-login.main
nathabonfim59 9509c3d
refactor(copilot): compatibility with new project structure
nathabonfim59 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's no longer a single package, we can't access the
Versions
variable. What would be the best approach here?Alternatively, we can ditch the "app registration" entirely. This will be only used by Microsoft to track how many users of a given application are using Copilot. But we're not sending this info in the request, so it could be removed without a big impact.