fix: use correct error variable in stderr copy check#892
Open
toller892 wants to merge 1 commit into
Open
Conversation
In gitServiceHandler, the stderr io.Copy goroutine checked the outer scope variable 'err' instead of the local 'erro' from the copy operation. This caused stderr copy errors to be silently swallowed when the outer err was nil, and incorrectly triggered when the outer err was non-nil. Change the condition from 'err != nil' to 'erro != nil' to properly detect and log stderr copy failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
gitServiceHandler(pkg/git/service.go), the stderrio.Copygoroutine checks the wrong error variable:The condition uses
err(from the outer scope — set byStdinPipe/StdoutPipe/StderrPipecalls) instead oferro(the actual error fromio.Copy).Effect:
erris nil (normal case): stderr copy errors are silently swallowed — the condition is false and the error is never logged.erris non-nil (pipe creation failed): the condition is always true, buterrois nil so the log message prints<nil>instead of the actual error.Fix
Change
err != niltoerro != nilon line 150:This is a single-character fix that ensures stderr copy failures are properly detected and logged.
Testing
go build ./pkg/git/...— passesgo test ./pkg/git/...— passes (1.781s)go vet ./pkg/git/...— clean