feat: add support for function keys #425
Open
+92
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyaillet
changed the title
pyaillet
force-pushed
the
feat/function_keys
branch
from
d0877f9 to
ae958c2
Compare
|
This PR is nearly 2 years old but would be useful. Any idea if it's every likely to be merged? |
pyaillet
force-pushed
the
feat/function_keys
branch
from
ae958c2 to
c56eabb
Compare
pyaillet
requested review from
andreynering and
meowgorithm
and removed request for
a team
pyaillet
force-pushed
the
feat/function_keys
branch
from
c56eabb to
76781a2
Compare
Author
|
No idea, I rebased it on main just in case. |
|
Thanks, I'll merge it into my fork, for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for making this cool projet :)
I noticed that function keys are currently not supported and saw that I am not the only one interested in this.
So here is a PR providing this feature.
I added some tests trying to follow the pattern that I saw. However do not hesitate to tell me if more tests are needed.
If you want to check it, I'm already using it here.