fix: handle OS-specific restrictions when moving Output frames
#619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #456
this handles the case where moving frames to the selected
Outputdirectory fails because of a different mount point.For instance, frames are initially stored in
/tmp/vhs*(on Linux). Renaming (moving) them from/tmpto an output directory located, let's say in/mnt/hdd(an external hard drive), will fail with aninvalid cross-device linkerror. While renaming to a directory located in/home/$USERwill succeed, as/tmpand/homedirectories (traditionally) share the same root mount point (/).There's a common practice to mount
/tmpontmpfs, so renaming will also fail as explained above.Another very subtle pitfall is that
os.Rename()also fails in case the user himself created an empty output directory for frames.To handle all of the above issues, we'll continue to use
os.Rename()and fallback toos.CopyFS()on failure.