feat(ansi): add x11 color names for osc 10-12#414
Open
mkotowski wants to merge 1 commit intocharmbracelet:mainfrom
Open
feat(ansi): add x11 color names for osc 10-12#414mkotowski wants to merge 1 commit intocharmbracelet:mainfrom
mkotowski wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
As per xterm's ctlseqs OSC 10-19 colors: > [...] are specified by name or RGB specification as per XParseColor This commit extends x/ansi XParseColor implementation to also support the X11 color names. Signed-off-by: Michał Kotowski <dev@mkotowski.dev>
Contributor
|
Thank you, @mkotowski, for sending this PR. Why don't you simply use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per xterm's ctlseqs OSC 10-19 colors:
This commit extends x/ansi
XParseColorimplementation to also support the X11 color names.Optionally,
vt'shandleDefaultColorcan also be extended to ignore strings longer than the max length of the passed string (65535u to match xterm's behavior withMAX_U_STRINGconst).