fix(powernap): use req.Notif to detect notifications in Router#790
Open
lexh wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(powernap): use req.Notif to detect notifications in Router#790lexh wants to merge 1 commit intocharmbracelet:mainfrom
lexh wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Router.Route compared req.ID to jsonrpc2.ID{} to distinguish
notifications from requests. Since jsonrpc2.ID{} has Num: 0, any
server-initiated request with integer ID 0 (e.g. the first outgoing
request from lsp_server/ty) was misrouted as a notification, skipping
its registered handler entirely.
Use req.Notif instead, which is correctly set by Request.UnmarshalJSON
based on whether the "id" field is present in the JSON.
Also guard against nil req.Params to prevent panics when a server
sends a request or notification without a params field.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Router.Routecomparedreq.IDtojsonrpc2.ID{}to distinguish notifications from requests. Sincejsonrpc2.ID{}hasNum: 0, any server-initiated request with integer ID 0 (e.g. the first outgoing request from lsp_server/ty) was misrouted as a notification, skipping its registered handler entirely.Use
req.Notifinstead, which is correctly set byRequest.UnmarshalJSONbased on whether the "id" field is present in the JSON.Also guard against nil
req.Paramsto prevent panics when a server sends a request or notification without a params field.CONTRIBUTING.md.