update to include reflow#795
Open
taigrr wants to merge 7 commits intocharmbracelet:mainfrom
Open
Conversation
aymanbagabas
reviewed
Mar 6, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 36.42% 39.54% +3.11%
==========================================
Files 209 21 -188
Lines 17591 2003 -15588
==========================================
- Hits 6408 792 -5616
+ Misses 10788 1102 -9686
+ Partials 395 109 -286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove ScrollbackLine struct - Scrollback now stores []uv.Line with a parallel []bool for soft-wrap state. Remove entries() and replaceLines() methods; Screen.reflowScrollback() accesses the fields directly since it owns the reflow logic. Addresses review feedback from @aymanbagabas.
Member
|
@aymanbagabas is this one good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.