-
Notifications
You must be signed in to change notification settings - Fork 2
Change from function api to template api #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3b990eb
Change from function api to template api
pearmini d798867
Wrap with fragment
pearmini 529da84
Remove comments
pearmini e8b5c27
Pass cloned node
pearmini 52faea5
Fix interpolateChildren
pearmini 250b963
Fix interpolateNodeChildren
pearmini c64db2e
Fix remove attributes
pearmini 80ac875
Update CI target branch
pearmini 0e49c7c
Update docs for charming dom
pearmini b93165f
Fix dead links
pearmini a11afa3
Optimize docs
pearmini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| import {tag} from "./tag.js"; | ||
|
|
||
| export const html = tag(null); | ||
| export const html = tag((string) => { | ||
| const div = document.createElement("div"); | ||
| div.innerHTML = string; | ||
| return div; | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| export {tag} from "./tag.js"; | ||
| export {svg} from "./svg.js"; | ||
| export {html} from "./html.js"; | ||
| export {attr} from "./attr.js"; | ||
pearmini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| import {tag} from "./tag.js"; | ||
|
|
||
| export const svg = tag("http://www.w3.org/2000/svg"); | ||
| export const svg = tag((string) => { | ||
| const g = document.createElementNS("http://www.w3.org/2000/svg", "g"); | ||
| g.innerHTML = string; | ||
| return g; | ||
pearmini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <DocumentFragment> | ||
| <g> | ||
| <circle | ||
| cx="20" | ||
| cy="50" | ||
|
|
@@ -14,4 +14,4 @@ | |
| cy="50" | ||
| r="10" | ||
| /> | ||
| </DocumentFragment> | ||
| </g> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <DocumentFragment> | ||
| <g> | ||
| <circle | ||
| r="0" | ||
| /> | ||
|
|
@@ -8,4 +8,4 @@ | |
| <circle | ||
| r="0" | ||
| /> | ||
| </DocumentFragment> | ||
| </g> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,5 @@ | |
| <span> | ||
| world | ||
| </span> | ||
| [object Object] | ||
| {key: "foo"} | ||
| </div> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.