Merged
Conversation
Collaborator
|
a pre-commit hook test seems to fail on on the commit titled "fix: claproar flaky test" can you have a look and confirm it successfully passes before merging? otherwise LGTM |
Collaborator
Author
|
The pre-commit hook bug has been fixed in the commit "fix: github workflow updates" |
Jamie001129
pushed a commit
to Jamie001129/recourse_benchmarks
that referenced
this pull request
Nov 16, 2025
Zahra/fix bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes failing and flaky tests by addressing multiple issues: fixed shadowing Python’s stdlib logging, added safe fallbacks and NaN handling in the Gravitational method (ensuring stable x_center computation and finite counterfactuals). These changes make the repo’s unit tests reliable and reproducible across runs.