init commit, ported the code from PROBE paper to our repo#24
Closed
HashirA123 wants to merge 0 commit intocharmlab:mainfrom
Closed
init commit, ported the code from PROBE paper to our repo#24HashirA123 wants to merge 0 commit intocharmlab:mainfrom
HashirA123 wants to merge 0 commit intocharmlab:mainfrom
Conversation
zkhotanlou
reviewed
Oct 20, 2025
methods/catalog/probe/reproduce.py
Outdated
| cost = np.mean(np.abs(test_factual.drop(columns=["prediction"]).values - df_cfs.drop(columns=["prediction"]).values).sum(axis=1)) | ||
| print("Average Cost (AC): ", cost) | ||
|
|
||
| if __name__ == "__main__": |
Collaborator
There was a problem hiding this comment.
The reproduce.py file should include unit tests to assert whether the output of the implemented method aligns with the reported results or not.
Collaborator
There was a problem hiding this comment.
Overall, the method is implemented correctly, thank you for your effort! However, the reproduce.py file should be written as unit tests instead of a standalone script. Please update it accordingly, and then run your implemented method on the available datasets and models. Finally, add the results to results.csv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was just quickly put together to copy over the implementation of the PROBE framework from this repo: https://github.com/MartinPawelczyk/ProbabilisticallyRobustRecourse
Will do more rigorous testing to make sure it works; however, the experiments from the original I was able to run.