-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add support for CFVAE #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
851495e
feat: Add support for CFVAE
ed8a6cf
fix: Fix experiments/*
956ba42
fix: Add results from CFVAE (base) to results.csv
e0761b8
fix: Fix categorical & continuous feature-specific l1 loss; Add oneho…
1ce027a
feat: Support customize default training process
c159094
fix: Fix cfvae (outside of reproduce.py) seed to 10_000_000
0e2f42e
feat: Add tolerance-based comparison for CFVAE reproduction results
98f4aec
Merge branch 'charmlab:main' into fix--CFVAE-Loss
Chenghao-Tan fb16004
Merge branch 'charmlab:main' into main
Chenghao-Tan 7579db6
Merge branch 'fix--CFVAE-Loss'
91c3001
fix: Reverse type fix in methods/api/recourse_method.py
1bbc46c
Merge branch 'main' into feat-CFVAE-Support
Chenghao-Tan cfa1a5a
fix: Fix logging
40bcea3
feat: Apply pytest to reproduce.py
ceadcfa
feat: Update CFVAE results.csv
3f98e27
chore: Format change
f4af196
fix: Temporarily remove torch gpu support
36ecf3f
Merge branch 'main' into feat-CFVAE-Support
Chenghao-Tan d7dcfc1
fix: Fix CFVAE check_counterfactuals
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit drops torch's GPU support since
pip install -r requirements-dev.txtin pre-commit won't read-f https://download.pytorch.org/whl/torch_stable.htmland therefore cannot findtorch==1.7.0+cu110.This is a backwards change. Please consider modifying
.github/workflows/pre-commit.yamllater, to add-f xxxafterpip install xxx, or to simply installtorch+cuversion manually.