Add a new method called "genre" to the main repo#30
Add a new method called "genre" to the main repo#30Jamie001129 wants to merge 0 commit intocharmlab:mainfrom
Conversation
amirhk
left a comment
amirhk
left a comment
There was a problem hiding this comment.
left questions for your review
cc @zkhotanlou
methods/catalog/genre/model.py
Outdated
| # Load checkpoint | ||
| try: | ||
| # Try new PyTorch (>= 1.13) | ||
| heckpoint = torch.load(full_path, map_location='cpu', weights_only=False) |
There was a problem hiding this comment.
other than this being a spelling mistake: "heckpoint"
why modify this code? what was the reasoning for having TypeError before?
There was a problem hiding this comment.
what is the reason for this extra file? the description at the top does not well-explain/-justify.
There was a problem hiding this comment.
again, i'm confused about _newtorch files?
will both *.py and *_newtorch.py files end up in the final submission? which is needed/correct?
There was a problem hiding this comment.
_newtorch.py are the scripts I created when developing in my python 3.12 environment with newer pytorch. After I moved to the repo's environment some errors due to the difference in pytorch occurred so I made modifications and kept both versions. _newtorch.py files will be removed.
methods/catalog/genre/genremlp.py
Outdated
There was a problem hiding this comment.
If this is a specific model that the GenRe methos works on, please add it to the model catalog
There was a problem hiding this comment.
What’s the difference between this implementation and the one in model.py (which was supposed to be named method.py)?
There was a problem hiding this comment.
The _newtorch.py files are for a later pytorch version in my own environment, they will be removed.
test_genre.ipynb
Outdated
There was a problem hiding this comment.
We’re not supposed to have notebook files in the main directory of the repository. To verify that your implementation works correctly, please add unit tests (including assertions) in reproduce.py to ensure that the outputs of your method align with the reported results in the paper.
3 participants
Except for the new "genre" folder in methods/catalog/ and a test_genre.ipynb, I've also modified the following scripts to integrate the new method.
experiments/experimental_setup.yaml
experiments/run_experiment.py
methods/init.py
methods/catalog/init.py