[CrayPMI] Missing headers #3887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritvikrao
approved these changes
Apr 23, 2025
matthiasdiener
requested changes
Apr 23, 2025
Contributor
matthiasdiener
left a comment
matthiasdiener
left a comment
There was a problem hiding this comment.
Can you try resetting the value of CMAKE_REQUIRED_INCLUDES after this test, similar to how CMAKE_REQUIRED_LIBRARIES is reset after the test?
ericjbohm
approved these changes
Apr 23, 2025
matthiasdiener
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for the appropriate pmi functionalities, we use the module defined variables to get the library path, but we don't do that for the headers.
In the (common) situation where we load cray modules but do not use the wrapper, this breaks. By explicitly adding the include path, we wont get issues.