CkPupPerPlaceData(): set numObjects correctly. #3899
Conversation
numObjects will set _numGroups and _numNodeGroups, and these need to be greater than the maximum index of a valid entry in _groupTable and _nodeGroupTable, respectively.
|
I tested this on a run that hung after 5 to 8 restarts. This fix kept it going for at least 15 restarts. |
There was a problem hiding this comment.
Looks good to me, but, after looking at the other code a bit, it's unclear to me why the original code wasn't working. Do you have any insight on when gID.idx would be greater than numGroups? I see your other issues that indicate that this happens when ckDestroy is called, but I don't see any code that actually changes the size of the Group ID Table when a chare array is deleted. I don't think that should be a blocker to merging this in, I'm mostly just curious about it (but it's also been a couple years since I've looked at the Charm++ code base, so perhaps I'm missing something obvious here).
ericjbohm
left a comment
ericjbohm
left a comment
There was a problem hiding this comment.
Looks like it should address the problem.
|
@rbuch If you delete a chare array and then create a new one, the ckNew() does not reuse groupIDs. In this case the largest groupID.idx will be greater than numGroups. |
In CkPupPerPlaceData(), numObjects will set _numGroups and _numNodeGroups, and these need to be greater than the maximum index of a valid entry in _groupTable and _nodeGroupTable, respectively.
This is a proposed fix for #3898 and #3678.
I will do some testing.