-
Notifications
You must be signed in to change notification settings - Fork 54
add the pingack benchmark to charm++ #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a short describing what the benchmark does.
Also.. is any purpose served by having the filename be ping rather than pingack?
I changed the file name and added a readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme text needs to be elaborated. (Also, you mean e.g. instead of "i.e." for the result data format. )
I suggest adding: Other than control messages all message sends happen from one process and all receives happen on the other process. This asymmetry is intentional so send related overheads can be separated easily from receive related overheads. This benchmark also exposes any bottlenecks in the message path, such as communication threads, serializing locks, etc. It has also been used to see how wide a processes should be in finegrained apllications (i.e. how many pes per processes.. or alternatively how many processes should one have on one physical node, for good performance).
Added a section explaining the benchmark's purpose and utility.
I changed the readme to add this information |
Adds ping-ack (with timing) as a converse benchmark