feat: profile component #282
Conversation
| @@ -0,0 +1,54 @@ | |||
| @props([ | |||
| 'user', | |||
| 'buttons', | |||
There was a problem hiding this comment.
i don't think you can pass html as a prop? and that this rather should be a named slot. but correct me if i'm wrong!
There was a problem hiding this comment.
om du har testat och det funkar så är det lugnt men vill veta att det funkar innan vi mergar detta
| <div class="flex size-30 flex-none items-center justify-center"> | ||
| @isset($user) | ||
| <x-avatar :image="$user->image" size="lg" /> | ||
| @else | ||
| <x-avatar size="lg" /> | ||
| @endisset | ||
| </div> |
There was a problem hiding this comment.
i don't think there needs to be a wrapping div for the avatar. there's also no need to check if there is a $user because this will never be used where there potentially isn't a user. x-avatar handles if the user doesn't have a profile picture
| <div class="flex size-30 flex-none items-center justify-center"> | |
| @isset($user) | |
| <x-avatar :image="$user->image" size="lg" /> | |
| @else | |
| <x-avatar size="lg" /> | |
| @endisset | |
| </div> | |
| <x-avatar :image="$user->image" size="lg" /> |
There was a problem hiding this comment.
Är wrapper onödig tar vi bort den. Check finns för att inte krasha i test
There was a problem hiding this comment.
vilka test? denna komponent används bara på profilsidan och man kan inte gå in på en profil som inte existerar. då kommer man komma till 404 innan denna sida renderar
| @endisset | ||
| </div> | ||
|
|
||
| <div class="flex grow flex-col gap-3 pr-10 text-slate-50"> |
There was a problem hiding this comment.
följer figmas design, kan tas bort
There was a problem hiding this comment.
finns ingen padding på denna div i figma?
| @isset($user) | ||
| {{ $user->username }} | ||
| @else | ||
| @username | ||
| @endisset |
There was a problem hiding this comment.
| @isset($user) | |
| {{ $user->username }} | |
| @else | |
| @username | |
| @endisset | |
| {{ $user->username }} |
same reason as above
| <p class="text-sm font-bold"> | ||
| {{ $sum }} | ||
| </p> | ||
| <span class="text-sm font-normal"> |
There was a problem hiding this comment.
| <span class="text-sm font-normal"> | |
| <span class="text-sm font-normal text-slate-200"> |
resources/views/profile.blade.php
Outdated
There was a problem hiding this comment.
again, please don't remove the layout
There was a problem hiding this comment.
du har raderat allt innehåll i denna fil. det ska vara där
borde vara Co-authored-by: Ella <[email protected]>
Co-authored-by: Ella <[email protected]>
|
@dcbwe hur går det med denna? Något som är oklart? |
|
|
profile.blade.php skapad i resources/views/components/