Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: input checkbox #296

Merged
merged 8 commits into from
Feb 11, 2025
Merged

feat: input checkbox #296

merged 8 commits into from
Feb 11, 2025

Conversation

beforeAW
Copy link
Contributor

@beforeAW beforeAW commented Feb 6, 2025

Unchecked:
checkbox-unchecked
Checked:
checkbox-checked

And an example is in the admin dashboard view.

@beforeAW beforeAW linked an issue Feb 6, 2025 that may be closed by this pull request
create checkbox input #214
Closed
@beforeAW beforeAW changed the title feat:input checkbox feat: input checkbox Feb 6, 2025
@beforeAW beforeAW marked this pull request as draft February 8, 2025 11:53
@ell-ska ell-ska temporarily deployed to feat-checkbox - u04-imdb-clone PR #296 February 8, 2025 12:11 — with Render Destroyed
@beforeAW beforeAW marked this pull request as ready for review February 8, 2025 12:17
@ell-ska ell-ska requested review from dcbwe and ell-ska February 8, 2025 12:17
ADchasacademy
ADchasacademy approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@ADchasacademy ADchasacademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

resources/views/components/input/checkbox.blade.php Outdated Show resolved Hide resolved
resources/views/components/input/checkbox.blade.php Outdated Show resolved Hide resolved
resources/views/components/input/checkbox.blade.php Outdated Show resolved Hide resolved
ell-ska
ell-ska reviewed Feb 10, 2025
View reviewed changes
resources/views/home.blade.php Outdated Show resolved Hide resolved
resources/views/components/input/checkbox.blade.php Outdated Show resolved Hide resolved
resources/views/components/input/checkbox.blade.php Outdated Show resolved Hide resolved
resources/views/components/input/checkbox.blade.php Outdated Show resolved Hide resolved
resources/views/components/input/checkbox.blade.php Show resolved Hide resolved
@ell-ska ell-ska temporarily deployed to feat-checkbox - u04-imdb-clone PR #296 February 10, 2025 14:08 — with Render Destroyed
@ell-ska
Copy link
Contributor

ell-ska commented Feb 10, 2025

can't go to the admin page to check it?
image

probably not related to this tho

@ell-ska
Copy link
Contributor

ell-ska commented Feb 10, 2025

can't go to the admin page to check it?
probably not related to this tho

fixed in #365

@beforeAW
Copy link
Contributor Author

#365 is now approved and merged

@ell-ska
Copy link
Contributor

ell-ska commented Feb 10, 2025

can you rebase this so i can test if the checked thing is working? :)

@ell-ska
Copy link
Contributor

ell-ska commented Feb 11, 2025 •
edited
Loading

everything looks good now except that the checked attribute either is true or null. it needs to be true or false for a form to work properly

image

dcbwe
dcbwe previously approved these changes Feb 11, 2025
View reviewed changes
Copy link

@dcbwe dcbwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

@beforeAW beforeAW requested review from ell-ska and dcbwe February 11, 2025 08:55
@beforeAW beforeAW dismissed dcbwe’s stale review February 11, 2025 09:01

want this cheaked by the person who out in the latest comment

@ell-ska ell-ska temporarily deployed to feat-checkbox - u04-imdb-clone PR #296 February 11, 2025 09:47 — with Render Destroyed
ell-ska
ell-ska approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ell-ska ell-ska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@beforeAW beforeAW merged commit 1452ca9 into main Feb 11, 2025
1 check passed
@beforeAW beforeAW deleted the feat-checkbox branch February 11, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ell-ska ell-ska ell-ska approved these changes

@ADchasacademy ADchasacademy ADchasacademy approved these changes

@DavidDyberg DavidDyberg Awaiting requested review from DavidDyberg

@dcbwe dcbwe Awaiting requested review from dcbwe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create checkbox input
4 participants
@beforeAW @ell-ska @dcbwe @ADchasacademy