Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 29, 2025

Bumps @types/should from 11.2.0 to 13.0.0.

Release notes

Sourced from @​types/should's releases.

13.0.0

Breaking changes

  1. Removed .enumerable, .enumerables (deprecated since 11.2.0)
  2. Fix for shouldjs/should.js#150

New

Added Typescript bindings (still considering this as beta as i am TS newbie)

Better Map Set equality

Map/Set/WeakMap/WeakSet equality checks

User @​BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks. Typical example that was working before this release:

const m1 = new Map([[{ a: 1 }, 11]]);
const m2 = new Map([[{ a: 1 }, 11]]);
m1.should.be.eql(m2)

And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:

const m1 = new Map([[{}, 11], [{}, 12]]);
const m2 = new Map([[{}, 11], [{}, 12]]);
m1.should.be.eql(m2)

This example is not that clear if it should assert or not, right? (it should).

As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0.

Consistency in bundles

For the long time (probably several years now) browser bundle and node bundle has little differences in globals. To make them sync i am doing such changes to bundles:

  1. Browser bundle will not contain window.Should any more (with capital S). It was deprecated for the long time. Just use window.should as is.
  2. Node bundle change global.should to be should function instead of getter attached to Object.prototype.
Changelog

Sourced from @​types/should's changelog.

13.0.0 / 2017-09-05

  • Removed .enumerable and .enumerables
  • Fixed .matching on Dates
  • Added TypeScript definitions

12.0.0 / 2017-08-28

  • Update should-equal to 2.x
  • Update entry points to do the same thing (global should entry)

11.2.1 / 2017-03-09

  • Fix .match(regex) for not supported cases
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/should](https://github.com/shouldjs/should.js) from 11.2.0 to 13.0.0.
- [Release notes](https://github.com/shouldjs/should.js/releases)
- [Changelog](https://github.com/shouldjs/should.js/blob/master/History.md)
- [Commits](shouldjs/should.js@11.2.0...13.0.0)

---
updated-dependencies:
- dependency-name: "@types/should"
  dependency-version: 13.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 29, 2025

Labels

The following labels could not be found: dependencies, npm. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@zhouyu123666 zhouyu123666 merged commit 8c4a36d into main Dec 30, 2025
5 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/types/should-13.0.0 branch December 30, 2025 04:56
@github-actions
Copy link

❤️ Great PR @dependabot[bot] ❤️

Thank you for your contribution to Chaterm! The growth of this project is inseparable from community feedback and contributions like yours.

We appreciate your time and effort in making Chaterm better! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants