feat: Remove "Delete Messages from Server" (delete_server_after) config option#8217
feat: Remove "Delete Messages from Server" (delete_server_after) config option#8217Hocuri wants to merge 18 commits into
Conversation
eb837a7 to
8e3e939
Compare
8e3e939 to
6ad3f80
Compare
… code, add some comments
…een(), test_mdn_asymmetric()
…re it tests was removed
52fe48d to
c70be03
Compare
| assert msg_in.text == msg_out.text | ||
|
|
||
|
|
||
| def test_verified_group_vs_delete_server_after(acfactory, tmp_path, lp): |
There was a problem hiding this comment.
This test tested how delete_server_after interacted with verified groups. We removed both features.
|
Co-authored-by: iequidoo <117991069+iequidoo@users.noreply.github.com>
Co-authored-by: iequidoo <117991069+iequidoo@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
OK, new plan after talking to @link2xt: We can likely do everything in delete_expired_imap_messages(). This function then has to be per-transport, and be called from imap loop. If Just as today, filter by download state, downloaded messages are deleted immediately, and non-downloaded messages are deleted after some time. (but more than 2 days, which is the current time). WRT Post-Messages:
|
Fix #8195
The most interesting change is in
imap.rsbecause there, messages are marked for immediate deletion on single-device chatmail profiles.WRT tests:
test_immediate_autodelete()tests the auto-deletion;test_imap_autodelete_fully_downloaded_msg()tests that even for a message that is split into pre- and post-message, both messages are deleted.test_one_account_send_bcc_setting()andtest_markseen_message_and_mdn()relies on the fact that messages stay on the server when bcc_self is on.Open question: Do we want to treat Nauta.cu like a chatmail server, in order to keep the old behavior on Nauta of auto-deleting? If not, I'll tell @adbenitez how he can do it in AC. In order to do this, need to find out in
fn fetch_many_msgs()whether the server is Nauta, probably by querying thetransportsSQL table