refactor: remove timesmearing#8226
Open
link2xt wants to merge 2 commits into
Open
Conversation
link2xt
force-pushed
the
link2xt/remove-timesmearing
branch
7 times, most recently
from
768f1cd to
8379b9d
Compare
link2xt
force-pushed
the
link2xt/remove-timesmearing
branch
from
8379b9d to
4f919ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One problem with removing it is that chat name or description may not be applied if it is done twice within the same second:
core/src/receive_imf.rs
Line 3304 in 6fb2f27
Previously the sender increased the timestamp each time, so it was clear which update is the latest, but now the tests that rename the chat multiple times in a row break without
sleep(1).Also had to insert time shift in some "golden" tests because otherwise they become flaky if the messages are sent by different senders and are received not in the order in which they are sent. If the second is the same, they were ordered in reception order, if the second is different they were ordered by timestamp and in the sending order.