Skip to content

Conversation

missytake
Copy link
Contributor

fix #616

@link2xt
Copy link
Contributor

link2xt commented Oct 7, 2025

Test is missing.

If we do this anyway, then I'd rather not hardcode Protonmail and allow other Version headers as well.

And this should not be allowed for outgoing mails, only for incoming ones.

@missytake missytake requested a review from link2xt October 7, 2025 14:55
@missytake
Copy link
Contributor Author

And this should not be allowed for outgoing mails, only for incoming ones.

Ah wait, that's still missing.

@missytake
Copy link
Contributor Author

missytake commented Oct 7, 2025

Now outgoing mails with Version: comment are prohibited and tests pass as well :)

Let's hope nobody spams nine users unencrypted with spam in the Version: comment

@missytake missytake changed the title filtermail: accept mails from protonmail filtermail: allow Version comment in incoming PGP messages Oct 7, 2025
@missytake missytake requested a review from link2xt October 10, 2025 07:28
@missytake missytake force-pushed the proton-version-comment-616 branch from 695a1a0 to c3c7884 Compare October 10, 2025 07:29
if payload.startswith(version_comment):
version_line = payload.splitlines()[0]
payload = payload.removeprefix(version_line)
print("Removed:" + version_line)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug printing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

encrypted messages from Proton Mail are rejected

2 participants