feat(notifications): show thread root context - #2011
Open
hmans wants to merge 3 commits into
Open
Conversation
…ns-thread-context * hmans/notifications-2-0-details: test(frontend): update notification E2E summaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on #1967 and should merge after it.
API compatibility
This adds the optional
NotificationGroup.thread_root_message_excerptfield. The change is additive against the parent branch; older clients ignore it, while newer clients gracefully omit the reference when talking to a server that does not return it.Verification
mise codegen-protobuf breaking proto --against '.git#branch=origin/hmans/notifications-2-0-details,subdir=proto'mise test-climise test-frontend(125 server files / 1,137 tests; 159 client files / 1,597 tests; 60 Storybook files / 180 tests; performance comparison passed)mise license-checkpnpm --dir apps/frontend check(0 errors, 0 warnings)Decision records