Skip to content

Conversation

@robin-deruyck
Copy link

@robin-deruyck robin-deruyck commented Apr 8, 2025

Summary

This PR finishes implementing the already intended behavior of specifying resources for the migration Job via hooks.migrate.resources. While the values.yaml contained a hooks.migrate.resources key, it was never actually injected into the migration template—so specifying resources there had no effect. This update properly references the user-defined resource values in migrations-job.yaml.

Why

  • The chart hinted that you could configure resources for the migration hook, but it wasn’t functional.

  • Some Kubernetes environments require explicit resource requests/limits for all workloads, including Jobs, or they won’t schedule properly.

What Changed

  • migrations-job.yaml: Added a {{- with .Values.hooks.migrate.resources }} block in the db-migrate-job container so that resource settings are included only if configured.
  • Ensures backward compatibility by omitting the resources: stanza when no values are provided.

Testing

  • Ran helm template locally with and without hooks.migrate.resources set to confirm correct rendering of the resources: block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant