fix: add missing resource injection for db-migrate-job #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR finishes implementing the already intended behavior of specifying resources for the migration Job via hooks.migrate.resources. While the values.yaml contained a hooks.migrate.resources key, it was never actually injected into the migration template—so specifying resources there had no effect. This update properly references the user-defined resource values in migrations-job.yaml.
Why
The chart hinted that you could configure resources for the migration hook, but it wasn’t functional.
Some Kubernetes environments require explicit resource requests/limits for all workloads, including Jobs, or they won’t schedule properly.
What Changed
migrations-job.yaml: Added a{{- with .Values.hooks.migrate.resources }}block in the db-migrate-job container so that resource settings are included only if configured.Testing