Fix notifications triggering even when nothing executed #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notifications ran even when no command was executed, e. g. when cancelling current prompt with ^C or confirming the command (pressing Enter) when there is an empty string so nothing gets executed. Now we check for `$1` variable provided by `preexec` hook to check if there actually was any command executed to avoid million of annoying popups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications ran even when no command was executed, e. g. when
cancelling current prompt with ^C or confirming the command (pressing
Enter) when there is an empty string, so nothing gets executed.
Now we check for
$1variable provided bypreexechook to check ifthere actually was any command executed to avoid million of annoying popups.