fix: remove SuperAdminAuthGuard from GET /partner/:name (closes #1042)#1049
Open
KJyang-0114 wants to merge 1 commit intochaynHQ:developfrom
Open
fix: remove SuperAdminAuthGuard from GET /partner/:name (closes #1042)#1049KJyang-0114 wants to merge 1 commit intochaynHQ:developfrom
KJyang-0114 wants to merge 1 commit intochaynHQ:developfrom
Conversation
- Removed @UseGuards(SuperAdminAuthGuard) decorator from GET :name endpoint - Updated ApiOperation description to indicate this is a public endpoint - Partner config data (logos, websites, social links) is non-sensitive - Other endpoints (POST, GET all, PATCH) remain admin-only Closes chaynHQ#1042
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the SuperAdminAuthGuard from the GET /v1/partner/:name endpoint to make it publicly accessible. This is needed because partner config data (logos, websites, social links) is being moved to the database and the frontend needs to call this endpoint to display partner branding.
Changes
@UseGuards(SuperAdminAuthGuard)decorator from GET :name endpoint@ApiOperationdescription to indicate this is a public endpointTesting
// Temporary super admin auth guardGET /v1/partner/[test-partner]without an auth tokenCloses #1042