-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App router migration error boundary component #1121
Merged
eleanorreem
merged 13 commits into
chaynHQ:next-js-migration
from
boodland:app-router-migration-error-boundary-component
Sep 20, 2024
Merged
App router migration error boundary component #1121
eleanorreem
merged 13 commits into
chaynHQ:next-js-migration
from
boodland:app-router-migration-error-boundary-component
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@boodland is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
eleanorreem
approved these changes
Sep 20, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eleanorreem
added a commit
that referenced
this pull request
Oct 2, 2024
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Make error boundary client component * Add ErrorBoundary component to root layout * Create app router error route test page --------- Co-authored-by: eleanorreem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#1083
What changes did you make?
Added ErrorBoundary component to root layout
Created /error-route-test page to throw an error
Why did you make the changes?
In order to catch unhandled errors within app router
Did you run tests?
Yes
Navigate to http://localhost:3000/error-route-test to check that the error is caught properly