chore: universal-developer-image already provides Google Cloud CLI#690
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe change removes Google Cloud CLI installation logic from the development Dockerfile. This includes deletion of the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-690-amd64 |
rgrunber
left a comment
There was a problem hiding this comment.
Seems reasonable. Just a partial revert of the block at https://github.com/che-incubator/che-code/pull/676/changes#diff-b3867b14785bf05eb0c09d7e9868fad2ceb8fcab8c3a12deefac0d5a485fc7b0 .
What does this PR do?
No need to add Google Cloud CLI at dev image level, as universal-developer-image already provides it.
See devfile/developer-images#253
What issues does this PR fix?
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folderSummary by CodeRabbit