Skip to content

chore: universal-developer-image already provides Google Cloud CLI#690

Merged
RomanNikitenko merged 1 commit intoche-incubator:mainfrom
RomanNikitenko:remove-gcloud
Apr 24, 2026
Merged

chore: universal-developer-image already provides Google Cloud CLI#690
RomanNikitenko merged 1 commit intoche-incubator:mainfrom
RomanNikitenko:remove-gcloud

Conversation

@RomanNikitenko
Copy link
Copy Markdown
Collaborator

@RomanNikitenko RomanNikitenko commented Apr 23, 2026

What does this PR do?

No need to add Google Cloud CLI at dev image level, as universal-developer-image already provides it.
See devfile/developer-images#253

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Summary by CodeRabbit

  • Chores
    • Removed Google Cloud CLI from the development Docker build process.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Click here to review and test in web IDE: Contribute

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fd06c41e-e84d-4349-9ba6-0dd1dba728c2

📥 Commits

Reviewing files that changed from the base of the PR and between f42c6a8 and dc0537e.

📒 Files selected for processing (1)
  • build/dockerfiles/dev.Dockerfile
💤 Files with no reviewable changes (1)
  • build/dockerfiles/dev.Dockerfile

📝 Walkthrough

Walkthrough

The change removes Google Cloud CLI installation logic from the development Dockerfile. This includes deletion of the GCLOUD_CLI_VERSION build argument, yum repository configuration, version verification steps, package installation (google-cloud-cli and libxcrypt-compat), cleanup commands, and the gcloud version verification invocation. No functional additions or modifications are introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing redundant gcloud installation because it's already provided upstream. It follows imperative mood convention and is concise at 66 characters.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Rebase Rules For Upstream Changes ✅ Passed PR modifies only build/dockerfiles/dev.Dockerfile, which is outside the code/ directory. Rebase rules requirement does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanNikitenko RomanNikitenko merged commit ec7cc85 into che-incubator:main Apr 24, 2026
13 of 14 checks passed
@RomanNikitenko RomanNikitenko deleted the remove-gcloud branch April 24, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants