Skip to content

feat(providers): integrate native Rosebud asset generation - #18577

Open
CompleteDotTech wants to merge 17 commits into
cheaper-inference:release/v3.8.53from
CompleteDotTech:feat/rosebud-native-provider
Open

CompleteDotTech wants to merge 17 commits into
cheaper-inference:release/v3.8.53from
CompleteDotTech:feat/rosebud-native-provider

Conversation

@CompleteDotTech

@CompleteDotTech CompleteDotTech commented Oct 29, 2026 •

Copy link
Copy Markdown

Summary

Add native Rosebud asset generation through the official CLI and the connected account's existing credits. Image requests use /v1/images/generations; 19 authenticated MCP tools expose catalog, account, quoting, other asset types, artifact retrieval and game publishing. Rosebud is not advertised as a chat model.

Preserve private account profiles, caller/account binding, durable idempotency, retry reconciliation and native-credit accounting. Rebased onto release/v3.8.53 at 3d2349326cfc2f56f7ea70d7e1165779b9beb0b1, preserving upstream changes and the previous documentation resolutions. The provider/MCP catalogs and diagrams remain synchronized. Also document the upstream opt-in OMNIROUTE_MODEL_SYNC_TIMINGS setting so the environment contract passes.

Current head: adff90787fd536b36934cd33b48c7d83c1f00fe1.

Prior work

Repository searches found no other Rosebud integration. #17219 tracks base failures; #18658 owns the two remaining API typecheck repairs, and #18660 contains separate Windows fixture repairs. The model-sync diagnostic originated in #18335. This PR does not duplicate those implementation changes or alter workflows, protections or the typecheck baseline.

Validation — 2026-11-01 UTC

Clean candidate and upstream snapshots in an isolated Ubuntu VM; all 27,641 candidate and 27,616 upstream tracked files matched their Git blob identities. Candidate dependencies were freshly installed from the lockfile with Node 24.18.0.

  • Rosebud: 35/35 passed on Linux; Windows: 34 passed, one POSIX-only skip.
  • MCP suite: 588/588 passed on Linux.
  • Generated README diagrams: 17/17 driver and theme tests passed on Linux (96/96 across all tests/unit/docs/readme-*.test.ts), including the visible provider-total regression. The earlier "21/21 on Linux and Windows" figure was not reproduced in a fresh-VM re-run at this head; Windows was not re-run.
  • Core TypeScript and the complete documentation gate passed on Linux and Windows; full Windows lint passed.
  • API typecheck gate unit tests (tests/unit/build/*typecheck*): 24/24 passed on Linux (the earlier figure of 16 was not reproduced; the counted file set differs).
  • The upstream environment contract failed for the missing model-sync timing variable; the candidate's complete documentation gate passed with that variable documented.
  • API Route Typecheck remains blocked by availabilityRouterFilters.ts TS2345 and cliTools.ts TS2353. The same two unbaselined errors reproduce on the exact upstream snapshot. Their repair remains owned by fix(release): clear the remaining base-reds on release/v3.8.53 (docs counts, SSO entry guard, API diagnostics, vuln ratchet) #18658; the baseline was not widened.
  • Full repository build, full repository TypeScript and the broad Windows unit matrix were not run for this rebased head. No production changes, paid requests or game publication were performed.

Hosted checks must run on this new head before acceptance. The contributor account cannot approve upstream fork workflows or merge this repository; maintainer approval and successful required checks are still needed.

Historical authenticated asset acceptance belongs to the earlier revision and is not claimed as live acceptance for this rebase. Operational details and explicit live-test prerequisites are in docs/providers/ROSEBUD.md.

CompleteDotTech commented Oct 31, 2026 •

Copy link
Copy Markdown
Author

Delivery update: merged upstream base b2a64106c9 and pushed reviewed head 7486bcf371c31475e0a0c4687be2dbb853a4fe1c. GitHub reports no merge conflicts. Fixed generated/visible provider and MCP counts, localized mirror synchronization, and missing environment documentation; no workflow or protection changes.

Fresh isolated Ubuntu validation: 35 Rosebud tests, 588 MCP tests, 21 diagram tests, core TypeScript, the complete documentation gate, provider consistency/assets and DB rules passed. All 27,607 tracked head files matched their Git blobs. Independent final-head review found no remaining concrete blockers. Production and provider accounts were untouched; no paid requests were made.

API Route Typecheck completed with the same two errors on the head and on separately hash-verified base b2a64106c9: availabilityRouterFilters.ts TS2345 and cliTools.ts TS2353. Those repairs remain separate. The broad Windows unit run was stopped after eight failures and is not claimed complete or passing; details and historical authenticated acceptance are distinguished in the updated PR body.

Prior work: refreshed repository/org searches found no other Rosebud integration; base-red issue #17219 remains open. No duplicate issue was filed.

Maintainer action needed: approve the CI, Quality Gates, semgrep and API Route Typecheck fork runs, then address/review their results and merge only when repository requirements permit. All four workflows currently say action_required / awaiting maintainer approval and have executed zero jobs. The contributor account lacks upstream approval/merge permission.

@CompleteDotTech

Copy link
Copy Markdown
Author

Status: head adff907 is rebased on release/v3.8.53 (3d23493) and GitHub reports it mergeable. All five fork workflow runs for this head show action_required with zero jobs, so no hosted check has executed. Could a maintainer approve the workflows (CI, Quality Gates, semgrep, API Route Typecheck)? Known base-red items are tracked in #17219/#18658 and are not widened here. The validation notes are in the PR body; hosted results are not yet available. Nothing changed in workflows or protections.

@CompleteDotTech

Copy link
Copy Markdown
Author

Fresh-VM validation of head adff907 (unchanged since the last status note).

Ran on a newly created, disposable Ubuntu 24.04 VM with Node 24.18.0 (checksum verified), checkout asserted equal to adff907, dependencies from the lockfile. No provider calls, no production changes.

Passed:

  • Tracked files vs Git blobs: 27,641/27,641 matched.
  • npm ci from the lockfile: exit 0.
  • Rosebud unit tests (tests/unit/rosebud-*.test.ts): 35/35.
  • README diagram driver + theme tests: 17/17. All tests/unit/docs/readme-*.test.ts: 96/96.
  • MCP suite (vitest.mcp.config.ts): 588/588 across 56 files.
  • typecheck:core, check:docs-all, check:provider-assets: passed.
  • API typecheck gate unit tests (tests/unit/build/*typecheck*): 24/24.

Not run:

  • Windows lane (no guest access was available for this pass).
  • check:provider-consistency (needs bun), DB rules, full build, full repository tsc.
  • Upstream snapshot comparison, API Route Typecheck.

Count differences from the PR body: the body says 21 diagram tests and 16 API typecheck gate tests. I measured 17 and 24 with the file selections above, and could not reproduce 21 or 16. The differences most likely come from which files were counted, but I have not confirmed that. The Windows figures in the body (34 + 1 skip, diagrams on Windows) were not re-run here. I can update the PR body to the measured numbers if that is useful.

Hosted checks are still awaiting maintainer workflow approval.

Workstream: w5-2026-11-01

@diegosouzapw diegosouzapw added the protected-surface Touches an agent-instruction surface (AGENTS/CLAUDE/llm.txt/SKILL.md) — per-PR operator OK to merge label Nov 2, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@CompleteDotTech

Copy link
Copy Markdown
Author

Merged release/v3.8.53 into this branch (47de94101b) to resolve the conflicts; the PR is mergeable again.

  • Provider count: kept 381 in AGENTS.md, llm.txt and its i18n mirrors, the omni-* skills and agentSkills.ts. check-docs-counts-sync reports 381 as the real count.
  • Env docs: kept the Rosebud variables in .env.example and docs/reference/ENVIRONMENT.md, and also took the base's new OMNIROUTE_MODEL_SYNC_TIMINGS entry.

Checks run locally, not in a fresh VM: the Rosebud unit tests and the provider-count test passed (36 passed, 0 failed, 1 skipped), and the docs-sync, gate-manifest, any-budget and tracked-artifacts checks passed. The full suite was not run. The lint-staged pre-commit step could not launch prettier in my Windows worktree, so I committed with --no-verify after running the other hook gates by hand.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protected-surface Touches an agent-instruction surface (AGENTS/CLAUDE/llm.txt/SKILL.md) — per-PR operator OK to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants