Skip to content

fix(quality): restore provider asset provenance validation - #18602

Closed
ahmedgo17390 wants to merge 1 commit into
cheaper-inference:release/v3.8.53from
ahmedgo17390:fix/provider-asset-provenance-squash
Closed

ahmedgo17390 wants to merge 1 commit into
cheaper-inference:release/v3.8.53from
ahmedgo17390:fix/provider-asset-provenance-squash

Conversation

@ahmedgo17390

Copy link
Copy Markdown
Contributor

Summary

  • Re-pin the provider-asset manifest snapshot from the unreachable former PR-head commit to the reachable squash commit that landed PR feat(providers): add Gisoo (OpenAI-compatible) #18112.
  • Preserve the existing 144 asset records, expected count, provenance statuses, and validator behavior.

Why

The manifest referenced ca7fc3f5ff3ec3e1f10e056faeb7332a568f6b28, a former PR-head commit that is not reachable from release/v3.8.53 after #18112 was squash-merged. The quality gate validates the manifest snapshot with local Git objects, so it deterministically failed with auditedCommit object does not exist.

b19031110bba41e322b28fcd44eba0d420fd4c9c is the reachable squash commit. Its public/providers tree was independently verified to match all 144 current provider asset blobs exactly.

Validation

  • npm run check:provider-asset-provenance — passed: 144/144 registered; proven=72, probable=69, unresolved=3, duplicate-groups=1.
  • node --import tsx/esm --test tests/unit/check-provider-asset-provenance.test.ts — 18 passed, 0 failed, 0 skipped.
  • Confirmed the replacement commit is an ancestor of the release tip.
  • Confirmed public/providers is unchanged and all 144 local asset blobs match the replacement snapshot.
  • git diff --check — passed.
  • Standard pre-commit hooks — passed.

Scope

This changes only the manifest header audit commit. It does not modify provider assets, source code, tests, workflows, runtime behavior, or the provenance validator.

⚠️ Base-red inherited: #17219. This resolves one independently reproducible Release-Green failure; unrelated existing release-base failures remain out of scope.

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for this, @ahmedgo17390. You found the real problem: the manifest's auditedCommit no longer existed after a squash, and that was failing provenance validation.

#18658 has just landed on release/v3.8.53. It changes the same manifest line and cleared this gate along with the other base-reds in #17219, so this PR has nothing left to add. I'm closing it as covered, not because anything was wrong with your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants