feat: add url monitor check to example projects#1125
Merged
stefanjudis merged 2 commits intomainfrom Jul 23, 2025
Merged
Conversation
sorccu
reviewed
Jul 23, 2025
sorccu
reviewed
Jul 23, 2025
While import isn't necessarily wrong, we only use require in the examples right now. Best to keep it consistent.
sorccu
approved these changes
Jul 23, 2025
Member
sorccu
left a comment
sorccu
left a comment
There was a problem hiding this comment.
I changed import -> require in the JS examples for consistency.
Collaborator
Author
|
Hah! Great call. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
Nothing too critical to see here. I only added the new URL monitor constructs to the example projects.
New Dependency Submission