-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Prometheus V2 - update cache documentation #1240
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe change updates the documentation for the Prometheus v2 integration. It adjusts the caching duration for responses from the Prometheus metrics endpoint, reducing it from 60 seconds to 50 seconds. The rate limit of 50 requests per minute and the recommended scrape interval of 60 seconds remain unchanged. There are no modifications made to any exported or public entity declarations. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vamos
Thanks for the review @tnolet :) The backend changes are still in-development. I'll merge this when the changes are deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
site/content/docs/integrations/prometheus-v2.md (1)
46-47
: Refine Cache Duration WordingThe cache duration update to 50 seconds is correct. However, the phrasing on line 46 ("cached during 50 seconds") is a bit awkward; it is more natural to say "cached for 50 seconds." This small nit-pick should help align the documentation with common usage.
Suggested diff:
- > The responses from this endpoint are cached during 50 seconds. + > The responses from this endpoint are cached for 50 seconds.🧰 Tools
🪛 LanguageTool
[uncategorized] ~46-~46: The preposition “for” seems more likely in this position.
Context: ...responses from this endpoint are cached during 50 seconds. > Any request made to this ...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
site/content/docs/integrations/prometheus-v2.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
site/content/docs/integrations/prometheus-v2.md
[uncategorized] ~46-~46: The preposition “for” seems more likely in this position.
Context: ...responses from this endpoint are cached during 50 seconds. > Any request made to this ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
Affected Components
Pre-Requisites
npm run lint
)Notes for the Reviewer
See https://github.com/checkly/checkly-backend/pull/6227
Prometheus V2 metrics will be cached for 50 seconds.