Skip to content

Conversation

@sorccu
Copy link
Member

@sorccu sorccu commented Jan 26, 2025

This PR adds support for TCP checks to the current provider, giving us a little more time to finish the full rewrite.

No attempts have been made to improve the code; the added resource is entirely adapted from other parts of the current codebase.

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

@sorccu sorccu force-pushed the simokinnunen/sc-23027/add-tcp-check-support-to-old-terraform-plugin branch from 08be2cc to 61aee03 Compare January 26, 2025 23:26
@sorccu sorccu force-pushed the simokinnunen/sc-23027/add-tcp-check-support-to-old-terraform-plugin branch from 61aee03 to f7c9468 Compare January 26, 2025 23:36
Antoine-C
Antoine-C previously approved these changes Jan 27, 2025
@sorccu sorccu force-pushed the simokinnunen/sc-23027/add-tcp-check-support-to-old-terraform-plugin branch from f7c9468 to 8e15b0b Compare January 28, 2025 13:00
@github-actions
Copy link

Terraform Format and Style 🖌success

Format Output

@sorccu sorccu merged commit 1669ac6 into main Jan 28, 2025
7 checks passed
@sorccu sorccu deleted the simokinnunen/sc-23027/add-tcp-check-support-to-old-terraform-plugin branch January 28, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants