Skip to content

fix: use updated limits for TCP check degraded/max response time [sc-23431] #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Mar 3, 2025

The maximum values were reduced at the backend level and the defaults were changed as well. This change syncs both values to current values used by the backend.

This change is technically backwards incompatible, but even the current version is broken right now if the user relies on default values.

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

The maximum values were reduced at the backend level and the defaults were
changed as well. This change syncs both values to current values used by the
backend.

This change is technically backwards incompatible, but even the current
version is broken right now if the user relies on default values.
@sorccu sorccu force-pushed the simokinnunen/sc-23431/tf-fix-tcp-check-degradedresponsetime-max branch from 4569c40 to be4e24c Compare March 3, 2025 17:15
@sorccu sorccu changed the title fix: use updated defaults for TCP check degraded/max response time [sc-23431] fix: use updated limits for TCP check degraded/max response time [sc-23431] Mar 3, 2025
@sorccu sorccu merged commit d5c69ec into main Mar 3, 2025
6 checks passed
@sorccu sorccu deleted the simokinnunen/sc-23431/tf-fix-tcp-check-degradedresponsetime-max branch March 3, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant