feat: add DNS monitor support #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All changes are backwards compatible, with the exception that some of the older resources lacked validation for their values. However, the accepted values were documented.
Terraform Format and Style 🖌
|
sorccu
changed the title
sorccu
force-pushed
the
simo/sim-153-tf-add-dns-monitor-support
branch
from
30e9778 to
f601ae1
Compare
…port Makes it clearer that port is part of the name server address.
Currently we're not. Test is expected to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
checkly_dns_monitorresource type which is used to manage DNS monitors.This PR also unifies the
alert_settingsattribute behind a shared helper, as it was getting unwieldy and there were minor differences in the documented behavior and defaults. The new schema produced by the helper is compatible with earlier behavior, with the exception that some of the older resource types did not validate their documented values. However, since the accepted values were documented, I think it's reasonable to now validate them. The new behavior is consistent for all resource types.Needs checkly/checkly-go-sdk#145.
Affected Components
Pre-Requisites
terraform fmtgo fmtplan&applycommand ofdemo/main.tffile do not produce diffsNotes for the Reviewer
New Dependency Submission