Skip to content

fix nudge display on settings/webhooks - #1077

Merged
ChibiBlasphem merged 2 commits into
mainfrom
pascal/mar-1224-analytics-page-is-no-longer-restricted-by-feature-access
Sep 5, 2025
Merged

fix nudge display on settings/webhooks#1077
ChibiBlasphem merged 2 commits into
mainfrom
pascal/mar-1224-analytics-page-is-no-longer-restricted-by-feature-access

Conversation

@Pascal-Delange

@Pascal-Delange Pascal-Delange commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Issues

  • "nudge" button is invisible if the side bar is folded (which should increasingly be its default status)
  • "webhooks" nudge button in setting was not handling all the cases where it should be displayed
  • "upgrade" button link in the hover did not do anything on click, only on "ctrl+click"

Attempts

  • I tried to make the nudge a miniature when the side bar is folded. I managed to make something that feels about right on the initial render, but the icon shifts back over the analytics page logo on the client re-render. I wasn't able to fix this.
  • on the webhooks setting page, the nudge logo flickers around when we refresh the page, if the webhooks setting page is selected

server render:
Capture d’écran 2025-09-05 à 11 36 00
client render:
Capture d’écran 2025-09-05 à 11 32 44

Some of the changes in this PR have been made with cursor, handle with care (especially the css)

@linear

linear Bot commented Sep 5, 2025

Copy link
Copy Markdown

@ChibiBlasphem
ChibiBlasphem force-pushed the pascal/mar-1224-analytics-page-is-no-longer-restricted-by-feature-access branch 4 times, most recently from 10f5bbb to 69d035f Compare September 5, 2025 11:20
@ChibiBlasphem

Copy link
Copy Markdown
Contributor

I fixed:

  • Hydration on left sidebar (nudge contains a "" which was inside the SidebarLink - which is also a )
  • Refactor Nudge styles to use class-variance-authority
  • Hoist the stopPropagation in the content rather than <a> to avoid trigger parent element when clicking in the hover card.

@ChibiBlasphem
ChibiBlasphem marked this pull request as ready for review September 5, 2025 11:22
@ChibiBlasphem
ChibiBlasphem requested a review from siiick September 5, 2025 11:22
@ChibiBlasphem
ChibiBlasphem force-pushed the pascal/mar-1224-analytics-page-is-no-longer-restricted-by-feature-access branch from 69d035f to fb9ded1 Compare September 5, 2025 14:14
@Pascal-Delange

Copy link
Copy Markdown
Contributor Author

Can't approve my own PR, but LGTM!

@ChibiBlasphem
ChibiBlasphem force-pushed the pascal/mar-1224-analytics-page-is-no-longer-restricted-by-feature-access branch from fb9ded1 to 6f5e910 Compare September 5, 2025 14:35
@ChibiBlasphem
ChibiBlasphem merged commit 8ed492d into main Sep 5, 2025
6 checks passed
@ChibiBlasphem
ChibiBlasphem deleted the pascal/mar-1224-analytics-page-is-no-longer-restricted-by-feature-access branch September 5, 2025 14:39
@siiick siiick mentioned this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants