Skip to content

Revert "chore: migrate to Bun package manager" #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siiick wants to merge 1 commit into from
Closed

Revert "chore: migrate to Bun package manager" #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 11 additions & 44 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,19 @@
# VCS
.git
.gitignore
**/.gitignore
**/.github

# IDE
.idea
.vscode
**/.vscode

# Node/Bun deps in context (use layer caching instead)
**/node_modules
node_modules

# Build outputs
packages/app-builder/build
**/build
**/dist

# Caches and tooling
**/.cache
**/.eslintcache
**/.next
**/.turbo
**/.vite
**/.github
**/.gitignore
**/.vscode
**/coverage

# Tests, reports, and stories
**/*.test.*
**/__tests__
**/playwright-report
**/storybook-static
**/test-results

# Local and misc
.env
.env.*
**/.env
**/.aws
**/.ssh
**/.DS_Store
*.local
*.log
**/env
**/venv

# Project files (root)
.dockerignore
Dockerfile
Dockerfile_local
.dockerignore
README.md
docker-compose.yml
docker-compose.yml
**/.DS_Store
**/venv
**/env
**/dist
**/build
18 changes: 9 additions & 9 deletions .github/dependabot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2
updates:
# Root workspace dependencies
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "weekly"
Expand All @@ -14,7 +14,7 @@ updates:
prefix: "chore(deps):"

# App Builder package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/app-builder"
schedule:
interval: "weekly"
Expand All @@ -31,7 +31,7 @@ updates:
prefix: "chore(app-builder):"

# Marble API package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/marble-api"
schedule:
interval: "weekly"
Expand All @@ -44,7 +44,7 @@ updates:
prefix: "chore(marble-api):"

# Shared package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/shared"
schedule:
interval: "weekly"
Expand All @@ -57,7 +57,7 @@ updates:
prefix: "chore(shared):"

# Tailwind Preset package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/tailwind-preset"
schedule:
interval: "weekly"
Expand All @@ -70,7 +70,7 @@ updates:
prefix: "chore(tailwind-preset):"

# Tests package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/tests"
schedule:
interval: "weekly"
Expand All @@ -83,7 +83,7 @@ updates:
prefix: "chore(tests):"

# TypeScript Utils package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/typescript-utils"
schedule:
interval: "weekly"
Expand All @@ -96,7 +96,7 @@ updates:
prefix: "chore(typescript-utils):"

# UI Design System package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/ui-design-system"
schedule:
interval: "weekly"
Expand All @@ -113,7 +113,7 @@ updates:
prefix: "chore(ui-design-system):"

# UI Icons package
- package-ecosystem: "bun"
- package-ecosystem: "npm"
directory: "/packages/ui-icons"
schedule:
interval: "weekly"
Expand Down
45 changes: 11 additions & 34 deletions .github/workflows/check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,49 +15,26 @@ jobs:
actions: read
steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2
with:
bun-version: 1.2.21
- name: Cache Bun
uses: actions/cache@v4
with:
path: |
~/.bun/install/cache
node_modules
packages/*/node_modules
key: ${{ runner.os }}-bun-${{ hashFiles('/bun.lock') }}
restore-keys: |
${{ runner.os }}-bun-
- uses: pnpm/action-setup@v4
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: '.tool-versions'
cache: 'pnpm'
- name: Setup Biome
uses: biomejs/setup-biome@v2
- name: Run Biome
run: biome ci .

- name: Install dependencies
run: bun install --frozen-lockfile

- name: Validate OpenAPI specs
run: |
bunx swagger-cli validate openapis/marblecore-api.yaml
bunx swagger-cli validate openapis/feature-access-api.yaml
bunx swagger-cli validate openapis/transfercheck-api.yaml
working-directory: packages/marble-api
- run: pnpm install --frozen-lockfile

- name: Generate API client and verify diff
run: |
bun run generate-api
- run: |
pnpm --filter marble-api exec swagger-cli validate openapis/marblecore-api.yaml
pnpm --filter marble-api exec swagger-cli validate openapis/feature-access-api.yaml
pnpm --filter marble-api exec swagger-cli validate openapis/transfercheck-api.yaml
pnpm --filter marble-api run generate-api
git diff --exit-code || (echo 'Generated API stubs not up to date with OpenAPI specification.' && exit 1)
working-directory: packages/marble-api

- name: Type check (all workspaces)
run: bun run -F "*" type-check

- name: Tests
run: bun run test:all

- name: Build app-builder
run: bun run -F app-builder build
- run: pnpm run -r type-check
- run: pnpm run test:all
- run: pnpm run -r build
46 changes: 0 additions & 46 deletions .github/workflows/e2e.yaml
View file
Open in desktop

This file was deleted.

30 changes: 30 additions & 0 deletions .github/workflows/playground.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: E2E tests

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
e2e:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
cache: pnpm
- run: pnpm install --frozen-lockfile
- run: pnpm --filter tests exec playwright install chromium-headless-shell
- run: pnpm --filter tests run test
- uses: actions/upload-artifact@v4
if: ${{ !cancelled() }}
with:
name: playwright-report
path: |
packages/tests/playwright-report/
packages/tests/trace.zip
retention-days: 1
Comment on lines +13 to +30

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 12 months ago

To fix this, you should add an explicit permissions block to the workflow YAML at the root level (to cover all jobs). The minimal starting point is contents: read, which provides only read access to repository contents. In most test workflows, this suffices unless you are writing to issues, pull requests, packages, etc. In this workflow, none of the steps indicate a need for elevated (write) permissions, so contents: read is appropriate.

Edit the file .github/workflows/playground.yaml: insert a permissions block immediately after the workflow name: and before the on: block. This aligns with YAML conventions and GitHub Actions documentation. No changes to imports or other workflow definitions are required.

Suggested changeset 1
.github/workflows/playground.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/playground.yaml b/.github/workflows/playground.yaml
--- a/.github/workflows/playground.yaml
+++ b/.github/workflows/playground.yaml
@@ -1,4 +1,6 @@
 name: E2E tests
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: E2E tests
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ node_modules
*.launch
.settings/
*.sublime-workspace
/.cursor/rules

# IDE - VSCode
.vscode/*
Expand Down
2 changes: 1 addition & 1 deletion .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Add files here to ignore them from prettier formatting
/.vscode/
bun.lock
pnpm-lock.yaml
packages-licenses.json

# app-builder
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 22.18.0
bun 1.2.21
pnpm 10.15.0
2 changes: 1 addition & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"version": "0.2.0",
"configurations": [
{
"command": "bun -F app-builder dev",
"command": "pnpm --filter app-builder run dev",
"name": "Launch app-builder",
"request": "launch",
"type": "node-terminal"
Expand Down
Loading