Skip to content

Pascal/allow field require update - #1103

Merged
Pascal-Delange merged 3 commits into
mainfrom
pascal/allow-field-require-update
Sep 12, 2025
Merged

Pascal/allow field require update#1103
Pascal-Delange merged 3 commits into
mainfrom
pascal/allow-field-require-update

Conversation

@Pascal-Delange

@Pascal-Delange Pascal-Delange commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Context

The new public API v1 rejects "additional properties", to reduce the risk of customers accidentally sending incorrect fields on the ingestion or decision API.
This also means it's no longer possible to add a field to the ingestion pipeline, then to the data model.
As a consequence, it was no longer possible to add a required field to a table that's used with real time API (not without downtime).

In this PR:

  • allow to edit field "required" status
  • add a warning when creating a required field on a table
  • avoid the field edit button disappearing in the table view with long field description

Prerequisite

checkmarble/marble-backend#1192

Screenshots

Capture d’écran 2025-09-12 à 10 44 53 Capture d’écran 2025-09-12 à 10 44 48
Capture d’écran 2025-09-12 à 10 45 09 Capture d’écran 2025-09-12 à 10 44 59

@siiick siiick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pascal-Delange
Pascal-Delange force-pushed the pascal/allow-field-require-update branch from feb4c23 to 668d3d1 Compare September 12, 2025 09:01
@Pascal-Delange
Pascal-Delange enabled auto-merge (rebase) September 12, 2025 09:01
@Pascal-Delange
Pascal-Delange merged commit e4bf5eb into main Sep 12, 2025
5 checks passed
@Pascal-Delange
Pascal-Delange deleted the pascal/allow-field-require-update branch September 12, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants