Skip to content

feat(in-app-analytics): improve design integration - #1140

Merged
siiick merged 20 commits into
mainfrom
feat/in-app-analytics-decisions-integration
Sep 30, 2025
Merged

feat(in-app-analytics): improve design integration#1140
siiick merged 20 commits into
mainfrom
feat/in-app-analytics-decisions-integration

Conversation

@siiick

@siiick siiick commented Sep 26, 2025

Copy link
Copy Markdown
Contributor
  • Improve empty state display
  • Improve X axis tick values display
  • Improve the UL parameters handling
  • Better UI integration
image

@siiick
siiick force-pushed the feat/in-app-analytics-decisions-integration branch from 5620df2 to 45529a0 Compare September 30, 2025 07:37
@siiick
siiick marked this pull request as ready for review September 30, 2025 07:38
@siiick
siiick force-pushed the feat/in-app-analytics-decisions-integration branch from 45529a0 to 18c7009 Compare September 30, 2025 07:39

@ChibiBlasphem ChibiBlasphem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There's a lot of comments that could be cleaned but I don't know if you want to keep them for late.

Also, as this is a new page with design aligned with the new margins/sizes, that would be good to use the new spacing tailwind values (ie: p-v2-md, gap-v2-sm, etc)

@siiick

siiick commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

LGTM.

There's a lot of comments that could be cleaned but I don't know if you want to keep them for late.

Also, as this is a new page with design aligned with the new margins/sizes, that would be good to use the new spacing tailwind values (ie: p-v2-md, gap-v2-sm, etc)

Yes I

LGTM.

There's a lot of comments that could be cleaned but I don't know if you want to keep them for late.

Also, as this is a new page with design aligned with the new margins/sizes, that would be good to use the new spacing tailwind values (ie: p-v2-md, gap-v2-sm, etc)

Indeed, the commented code block is for later.
I have applied the new spacings, thanks !

@siiick
siiick merged commit 840ec17 into main Sep 30, 2025
5 checks passed
@siiick
siiick deleted the feat/in-app-analytics-decisions-integration branch September 30, 2025 08:25
@sentry

sentry Bot commented Sep 30, 2025

Copy link
Copy Markdown

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants